-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI/UX improvements #221
UI/UX improvements #221
Conversation
Should |
Yes. As a user, after adding a new person, the natural intuition is to check that the new person has been added. While we have a confirmation message, it would be better to switch to the all persons view so that users can visually confirm that their new person has been added. If they were still on the groups view, visual confirmation would not be possible as it takes another command to add the new person to the group.
Yes. Similarly, after deleting a person, the natural intuition would be to verify visually, by comparing the current list of people with the previous list of people they saw. If the person is no longer there, users can rest assured that the person is deleted. If they were initially on the groups view, with 3 people. They would expect to see a new list of 2 people. Switching them to the all persons view would throw them off slightly as they are now presented with a list of potentially more people. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
#221 (comment) Ok thanks for the reply |
add-date
,del-meeting
,add-debt
should not reset the list of people back to the full list if they are currently viewing a certain groupupdateFilteredPersonList
with no params will now check if there is acurrentGroup
to be displayed, and if so uses the appropriate predicate. Else it uses the predicate to show all persons.