Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX improvements #221

Merged
merged 5 commits into from
Apr 7, 2021
Merged

UI/UX improvements #221

merged 5 commits into from
Apr 7, 2021

Conversation

chesterhow
Copy link

@chesterhow chesterhow commented Apr 7, 2021

@chesterhow chesterhow added type.Enhancement An enhancement to an existing story priority.Medium Nice to have severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. labels Apr 7, 2021
@chesterhow chesterhow added this to the v1.4 milestone Apr 7, 2021
@chesterhow chesterhow requested review from a team, ivantjh and Assyarul and removed request for a team April 7, 2021 06:09
@ivantjh
Copy link
Collaborator

ivantjh commented Apr 7, 2021

Should AddCommand always return to the all person view? Should DeleteCommand still stick to the groups view?

@chesterhow
Copy link
Author

Should AddCommand always return to the all person view?

Yes. As a user, after adding a new person, the natural intuition is to check that the new person has been added. While we have a confirmation message, it would be better to switch to the all persons view so that users can visually confirm that their new person has been added.

If they were still on the groups view, visual confirmation would not be possible as it takes another command to add the new person to the group.

Should DeleteCommand still stick to the groups view?

Yes. Similarly, after deleting a person, the natural intuition would be to verify visually, by comparing the current list of people with the previous list of people they saw. If the person is no longer there, users can rest assured that the person is deleted.

If they were initially on the groups view, with 3 people. They would expect to see a new list of 2 people. Switching them to the all persons view would throw them off slightly as they are now presented with a list of potentially more people.

Copy link
Collaborator

@ivantjh ivantjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ivantjh
Copy link
Collaborator

ivantjh commented Apr 7, 2021

#221 (comment) Ok thanks for the reply

@chesterhow chesterhow merged commit 2efa212 into master Apr 7, 2021
@chesterhow chesterhow deleted the chesterhow/uiux branch April 7, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.Enhancement An enhancement to an existing story
Projects
None yet
2 participants