Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for 'Model' component #231

Merged
merged 5 commits into from
Nov 6, 2021
Merged

Update tests for 'Model' component #231

merged 5 commits into from
Nov 6, 2021

Conversation

YeluriKetan
Copy link
Collaborator

Changes

  • Remove unused methods like hashCode()
  • Update and increase testing for the model component
  • Purge SampleDataUtil and replace its uses with TypicalXXXXLists
  • Update self PPP

Issues

Preview

  • IntelliJ coverage report
    image

  • Jacoco coverage report
    image

Testing

Test application to check for any regressions from removing existing methods.

@YeluriKetan YeluriKetan added this to the v1.4 milestone Nov 5, 2021
@YeluriKetan YeluriKetan self-assigned this Nov 5, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #231 (9774741) into master (d577b66) will increase coverage by 3.15%.
The diff coverage is 95.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #231      +/-   ##
============================================
+ Coverage     71.82%   74.97%   +3.15%     
- Complexity      786      813      +27     
============================================
  Files           122      121       -1     
  Lines          2353     2278      -75     
  Branches        254      250       -4     
============================================
+ Hits           1690     1708      +18     
+ Misses          578      513      -65     
+ Partials         85       57      -28     
Impacted Files Coverage Δ
src/main/java/seedu/address/model/FriendsList.java 100.00% <ø> (+5.88%) ⬆️
src/main/java/seedu/address/model/GamesList.java 100.00% <ø> (+17.85%) ⬆️
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 100.00% <ø> (+5.26%) ⬆️
...main/java/seedu/address/model/friend/FriendId.java 100.00% <ø> (+20.00%) ⬆️
.../model/friend/FriendIdMatchesKeywordPredicate.java 100.00% <ø> (+14.28%) ⬆️
...in/java/seedu/address/model/friend/FriendName.java 100.00% <ø> (+16.66%) ⬆️
...main/java/seedu/address/model/friend/Schedule.java 87.17% <ø> (+14.67%) ⬆️
.../seedu/address/model/friend/UniqueFriendsList.java 100.00% <ø> (+4.54%) ⬆️
...del/friend/exceptions/InvalidDayTimeException.java 100.00% <ø> (+50.00%) ⬆️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d577b66...9774741. Read the comment docs.

@YeluriKetan YeluriKetan marked this pull request as ready for review November 6, 2021 04:38
Copy link
Collaborator

@MarcusTXK MarcusTXK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job with the tests and cleanup of unused code. Tested and all works well.

@MarcusTXK MarcusTXK merged commit a53eb3f into master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase testing for Model component
3 participants