-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make link immutable #218
Make link immutable #218
Conversation
xiangjunn
commented
Nov 2, 2021
•
edited
edited
- Make link and unlink immutable
- Shows error message if contact already linked/not linked to event
- Fix cedit and eedit allowing the removal of a non-existing tag
- Make link and unlink work with undo
- Fix cedit and eedit allowing the adding of a already existing tag
Codecov Report
@@ Coverage Diff @@
## master #218 +/- ##
============================================
+ Coverage 68.94% 69.41% +0.47%
- Complexity 1004 1029 +25
============================================
Files 129 129
Lines 3355 3404 +49
Branches 433 450 +17
============================================
+ Hits 2313 2363 +50
+ Misses 857 849 -8
- Partials 185 192 +7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor but important changes. Otherwise, looks good.
src/main/java/seedu/address/logic/commands/event/EUnlinkCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/event/EUnlinkCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/commands/event/EUnlinkCommand.java
Outdated
Show resolved
Hide resolved
Also, please add more test cases. See codecov report to see where you are lacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but there are some other changes to be made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the user tries to delete a tag that does not exist, the program will give an error and show a red message. However, if the user tries to unlink something that is not linked, the program allows it but displays the message that it is not linked. This is quite inconsistent. Also, you forgot to implement the check for adding new tags if there are already duplicate tags in CEdit and EEdit commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I made changes to the PR, I shall not approve this PR. Even though it is showing green, please wait for Janice review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Good job!!