Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undo bug for find and view #219

Merged
merged 11 commits into from
Nov 4, 2021
Merged

Fix undo bug for find and view #219

merged 11 commits into from
Nov 4, 2021

Conversation

pcgiang
Copy link
Collaborator

@pcgiang pcgiang commented Nov 3, 2021

No description provided.

@pcgiang
update undo command
3aef9ce 
- need to fix 3 failed test cases
- clist cannot undo yet
@chunweii chunweii added priority.High Should be resolved first, failing which, the project will not work severity.High A flaw that affects most users and causes major problems for users type.Bug Something isn't working labels Nov 3, 2021
@chunweii chunweii added this to In progress in tP Project Dashboard via automation Nov 3, 2021
@chunweii chunweii added this to the v1.4 milestone Nov 3, 2021
@pcgiang pcgiang linked an issue Nov 3, 2021 that may be closed by this pull request
Undo does not work for displaying contacts and events #220
Closed
@codecov
Copy link

codecov bot commented Nov 4, 2021 •
edited

Codecov Report

Merging #219 (b36fa86) into master (675d51e) will increase coverage by 0.04%.
The diff coverage is 64.44%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
+ Coverage     68.89%   68.94%   +0.04%     
- Complexity      982     1004      +22     
============================================
  Files           125      129       +4     
  Lines          3302     3355      +53     
  Branches        432      433       +1     
============================================
+ Hits           2275     2313      +38     
- Misses          843      857      +14     
- Partials        184      185       +1
Impacted Files Coverage Δ
src/main/java/seedu/address/MainApp.java 0.00% <0.00%> (ø)
...du/address/logic/commands/contact/CAddCommand.java 100.00% <ø> (ø)
...dress/logic/commands/contact/CBookmarkCommand.java 100.00% <ø> (ø)
...address/logic/commands/contact/CDeleteCommand.java 100.00% <ø> (ø)
...u/address/logic/commands/contact/CEditCommand.java 95.23% <0.00%> (-0.05%) ⬇️
...u/address/logic/commands/contact/CFindCommand.java 100.00% <ø> (ø)
...address/logic/commands/contact/CUnmarkCommand.java 43.47% <ø> (ø)
...u/address/logic/commands/contact/CViewCommand.java 93.75% <ø> (-0.37%) ⬇️
...eedu/address/logic/commands/event/EAddCommand.java 93.75% <ø> (-0.37%) ⬇️
...address/logic/commands/event/EBookmarkCommand.java 100.00% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 675d51e...b36fa86. Read the comment docs.

@pcgiang pcgiang marked this pull request as ready for review November 4, 2021 06:10
tP Project Dashboard automation moved this from In progress to Review in progress Nov 4, 2021
xiangjunn
xiangjunn requested changes Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@xiangjunn xiangjunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. All commands seem to work with undo/redo beside mark and link, which is not the issue of undo/redo. LGTM

src/main/java/seedu/address/logic/commands/general/GeneralCommand.java Outdated Show resolved Hide resolved
tP Project Dashboard automation moved this from Review in progress to Reviewer approved Nov 4, 2021
@xiangjunn xiangjunn merged commit 1e72508 into master Nov 4, 2021
tP Project Dashboard automation moved this from Reviewer approved to Done Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunweii chunweii chunweii left review comments

@xiangjunn xiangjunn xiangjunn approved these changes

Assignees
No one assigned
Labels
priority.High Should be resolved first, failing which, the project will not work severity.High A flaw that affects most users and causes major problems for users type.Bug Something isn't working
Projects
tP Project Dashboard
Done
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Undo does not work for displaying contacts and events
3 participants
@pcgiang @xiangjunn @chunweii