Fix the esort and emark bug #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunweii
added
type.Bug
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
============================================
- Coverage 75.76% 75.67% -0.09%
+ Complexity 1166 1157 -9
============================================
Files 129 129
Lines 3420 3421 +1
Branches 450 451 +1
============================================
- Hits 2591 2589 -2
- Misses 691 694 +3
Partials 138 138
Continue to review full report at Codecov.
|
xiangjunn
requested changes
Nov 7, 2021
Comment on lines
287
to
288
| || ( | ||
| other instanceof AddressBook // instanceof handles nulls |
There was a problem hiding this comment.
Suggested change
| || ( | |
| other instanceof AddressBook // instanceof handles nulls | |
| || (other instanceof AddressBook // instanceof handles nulls |
Comment on lines
261
to
296
| .append("; Email: ") | ||
| .append(getEmail()) | ||
| .append(getPhone() != null ? "; Phone: " + getPhone() : "") // optional | ||
| .append(getAddress() != null ? "; Address: " + getAddress() : "") // optional | ||
| .append(getZoomLink() != null ? "; Zoom Link: " + getZoomLink() : "") // optional | ||
| .append(getTelegramHandle() != null ? "; Telegram: " + getTelegramHandle() : ""); // optional | ||
| .append("; Email: ") | ||
| .append(getEmail()) | ||
| .append(getPhone() != null ? "; Phone: " + getPhone() : "") // optional | ||
| .append(getAddress() != null ? "; Address: " + getAddress() : "") // optional | ||
| .append(getZoomLink() != null ? "; Zoom Link: " + getZoomLink() : "") // optional | ||
| .append(getTelegramHandle() != null ? "; Telegram: " + getTelegramHandle() : ""); // optional |
There was a problem hiding this comment.
Why are you changing all the indentations from 8 to 4 spaces? Java coding standard is 8 spaces for wrapped lines.
Comment on lines
175
to
176
| || ( | ||
| other instanceof UniqueEventList // instanceof handles nulls |
There was a problem hiding this comment.
Why did you split it like this?
xiangjunn
approved these changes
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #222
Closes #234