Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UG final v1.4 #236

Merged
merged 62 commits into from
Nov 8, 2021
Merged

UG final v1.4 #236

merged 62 commits into from
Nov 8, 2021

Conversation

Copy link
Collaborator

@Gordon25 Gordon25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM, just some minor changes

SoConnect comes with some sample contacts and events upon installation.
</div>
<div markdown="span" class="alert alert-primary">:bulb: **Tip:**
If SoConnect does not start by double-clicking, you can check this
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe checkout sounds better

docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
docs/UserGuide.md Show resolved Hide resolved
docs/UserGuide.md Outdated Show resolved Hide resolved
tP Project Dashboard automation moved this from In progress to Review in progress Nov 8, 2021
@@ -633,7 +633,7 @@ You must provide **at least one** of the optional _fields_.
* `INDEX` **must be a positive integer**. e.g. 1, 2, 3, …
* Start time and End Time should be of format **dd-MM-yyyy HH:mm** (date-MONTH-year HOUR:minute in 24-hour format).
* End Time should be **chronologically after** the Start Time.
* You **cannot** edit an event to the same name as an existing event.
* You **cannot** edit an event to the **same name** as an existing event.
</div>

**Examples:**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for eunmark second example, can include the link back to cunmark also

@chunweii chunweii marked this pull request as ready for review November 8, 2021 14:06
tP Project Dashboard automation moved this from Review in progress to Reviewer approved Nov 8, 2021
@pcgiang pcgiang merged commit 0733716 into master Nov 8, 2021
tP Project Dashboard automation moved this from Reviewer approved to Done Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment