Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester D] Optional fields not wrapped in square brackets #171

Closed
nus-se-script opened this issue Oct 28, 2022 · 2 comments
Closed

[PE-D][Tester D] Optional fields not wrapped in square brackets #171

nus-se-script opened this issue Oct 28, 2022 · 2 comments
Labels
priority.Low Good to do type.Documentation Improvements or additions to documentation
Milestone
v1.4

Comments

@nus-se-script
Copy link

image.png
Why not add n/NAME j/POSITION d/DEPARTMENT [p/PHONE] [e/EMAIL] [a/ADDRESS] [l/LEAVE] [t/TAG]…​ if in the command format the square bracket has been defined as an optional field?

Labels: type.DocumentationBug severity.Medium
original: TheSoggy/ped#5
@kevinchangjk
Copy link

Accepted, will fix with #157.

@kevinchangjk kevinchangjk added priority.Low Good to do type.Documentation Improvements or additions to documentation labels Oct 29, 2022
@kevinchangjk kevinchangjk added this to the v1.4 milestone Oct 29, 2022
@kevinchangjk kevinchangjk mentioned this issue Oct 29, 2022
Closed
@kevinchangjk
Copy link

Fixed in #157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority.Low Good to do type.Documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
3 participants
@nus-se-script @kevinchangjk @chao890