Skip to content
This repository has been archived by the owner on Dec 27, 2023. It is now read-only.

Finalise PPP #221

Merged
merged 3 commits into from
Nov 13, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions docs/team/bwangpj.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,45 +19,44 @@ While it has a Graphical User Interface, most of its user interactions happen vi

### Enhancements implemented

1. Filter command to allow users to filter contacts by Tag
2. Store command history and allow navigating between previous commands using up/down arrow keys, similar to an actual CLI
1. Filter command to allow users to filter contacts by Tag, and associated tests
2. Store command history and allow navigating between previous commands using up/down arrow keys, similar to an actual CLI, and associated tests

### Contributions to the UG

- Describe useful features relevant to NUS SoC students at the start, i.e. filtering and navigating between commands using up/down arrow keys
- Include labelled UI diagram of the various information that is stored and displayed in the UI
- Describe useful features relevant to NUS SoC students at the start of the UG, i.e. filtering and navigating between commands using up/down arrow keys
- Include labelled UI diagram of the various information that is stored and displayed in the UI
- Include documentation for `filter` command
- Explain and emphasise that indexing is 1-based and not 0-based
- Explain and emphasise how duplicate contacts are handled - only by name, and only with an exact match of name
- Documentation for `filter` command
- Clarify how input commands with empty fields are handled

### Contributions to the DG

- Include initial list of all user stories brainstormed
- Describe implementation of `edit` and `filter` commands, and associated UML diagrams
- Describe implementation of:
- `edit` command
- `filter` command
- navigation between command history using up/down arrow keys; including the `UI` component as well as description of how the feature is implemented using `CommandBoxHistory`

and their associated UML diagrams.
- Add Planned Enhancements appendix to the DG

### Contributions to team-based tasks

- Renaming objects in the code to remove traces of AB3, and the associated big refactor
- Rename objects in the code to remove traces of AB3, and the associated big refactor
- Remove traces of AB3 from Jekyll
- Remove tutorials and images used in tutorials from the docs
- Release of v1.3 (trial)
- Help to triage PE-D bugs for Planned Enhancements
- Miscellaneous checkstyle corrections to pass checkstyle
- Triage and collate the PE-D bugs for Planned Enhancements
- Help with miscellaneous checkstyle corrections to pass checkstyle

### Review/mentoring contributions

- Look through all PRs reviewed by me to catch things that may have been missed.
- Review PRs to catch things that may have been missed.
E.g. https://github.com/AY2324S1-CS2103-W14-3/tp/pull/71#discussion_r1361430312
- Contribute to discussions on GitHub, Telegram and Zoom.

### Contributions beyond the project team

- Put a good amount of effort into [finding bugs during the PE-D](https://github.com/AY2324S1-CS2103T-T17-4/tp/issues?q=is%3Aissue+c%5D).

## Contributions to the developer guide (extracts)

//NOTE optional

## Contributions to the user guide (extracts)

//NOTE optional
Loading