forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DG and UG #253
Merged
ncmathan
merged 18 commits into
AY2324S1-CS2103T-T09-2:master
from
Mahidharah:Branch-Documentation
Nov 13, 2023
Merged
Update DG and UG #253
ncmathan
merged 18 commits into
AY2324S1-CS2103T-T09-2:master
from
Mahidharah:Branch-Documentation
Nov 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/Mahidharah/tp: (23 commits) fix user guide format fix checkstyle update user guide format update ug header Update projects.yml to work Update index.md to work Update Documentation.md to work Update DeveloperGuide.md to work Update page.html to work Update default.html to work Update alt-page.html to work Update custom-head.html to work Update header.html to work Update head.html to work Update PPP fix ug header update ug heading fix typo in ug fix bugs fix check style errors ...
* 'master' of https://github.com/Mahidharah/tp: Fix bugs Fix error message and edit command bugs Update PPP Update PPP Fixes bug regarding missing deadline and empty deadline
…Branch-Tests * 'Branch-Tests' of https://github.com/Mahidharah/tp: fix checkstyles test cases for delete developer role parser test cases for adding roles test cases for adding roles Create edit client command tests Fix bugs Edits for checkstyle Add test cases Undo some checks added previously Add punctuation and remove trailing spaces fix bugs checkstyle for ppp checkstyles for ppp checkstyle for ppp fix bugs and update UG accordingly fix bugs related to delete-developer-role feature
… into Branch-Documentation * 'Branch-Documentation' of https://github.com/Mahidharah/tp: (36 commits) fix checkstyles fix test cases Undo Redo Command test cases Fix failing test Fix import checkstyle issues Fix checkstyle issues VersionedAddressBook test cases Update DeveloperRoles.txt Update ClientRoles.txt Add tests for edit project command and mark/unmark commands delete client and developer roles test cases add-client role and add developer role tests Write tests for edit commands fix CI fix checkstyles fix CI Add use cases and planned enhancements fix checkstyles Add and delete role's developer guide and user stories Undo/Redo feature DG ... # Conflicts: # DeveloperRoles.txt # docs/UserGuide.md
Added tables for all features for concistency
* master: Update UserGuide.md Update UserGuide.md Update UserGuide.md Update UserGuide.md
… into Branch-Documentation * 'Branch-Documentation' of https://github.com/Mahidharah/tp: Fix checkstyle issues Fix UG Add punctuation Fix punctuation and other bugs in code Fix documentation bugs in UG Update user guide modify UG Update displayed messages # Conflicts: # docs/UserGuide.md
ncmathan
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than codestyle, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added puml files for add and delete sequence diagrams
Fixed Documentation bugs in UserGuide
fixes #210