[PE-D][Tester A] Entering of invalid dates does not throw error

[soc-pe-bot]

Typing an invalid date (31 Feb) causes an appointment of 28 Feb to be added.

---

Labels: type.FunctionalityBug severity.Low
original: RoeReRe/ped#3

[kohkaijie]

This issue is caused due to our method isValidAppointmentTime using the default formatter which adjusts the date to a valid one when an invalid date. It seems that as long as the month and date are within the constraints (i.e 1-12 for month and 1-31 for date) an invalid input such as add-appt pic/S1112228G dic/S2223338G time/2000-02-31 13:00 will cause the parser to automatically adjust the date to be the last day of the specified month.

If we are unable to fix the parser, the best fix for this problem would be to state in the user guide that if the date exceeds the number of days for that specified month but is still within 31, the app will automatically input the last day of that month, and justify it as an intended feature :)

[cmHuang777]

As discussed, we will just add .withResolverStyle(ResolverStyle.STRICT) to our DateTimeFormatter to fix this bug