Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PE-D bug fix #213

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

cmHuang777
Copy link

Fixes the issues assigned to me, raised by the PE-D testers.

Updated UG:

AppointmentTime:

@cmHuang777 cmHuang777 added this to the v1.4 milestone Nov 9, 2023
@cmHuang777 cmHuang777 requested a review from a team November 9, 2023 14:19
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #213 (67a44cb) into master (2be2c0a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #213      +/-   ##
============================================
+ Coverage     70.51%   70.52%   +0.01%     
  Complexity      718      718              
============================================
  Files           114      114              
  Lines          2601     2602       +1     
  Branches        281      281              
============================================
+ Hits           1834     1835       +1     
  Misses          662      662              
  Partials        105      105              
Files Coverage Δ
...edu/address/model/appointment/AppointmentTime.java 100.00% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

@tanveersingh10 tanveersingh10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@kohkaijie kohkaijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Well done on the UG changes and appointmentTime bug fix!

- EMAIL must contain email domain (eg. `@gmail.com`).
- TAG must indicate Priority Level of the Patient and be one of the following:
- Low
- Medium
- High
- EMERGENCY_CONTACT must contain valid emergency contact number, which needs to be a valid phone number.
- EMERGENCY_CONTACT must contain valid emergency contact number, which needs to be a valid phone number. This number can be the same the person's contact number.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to justify why? Or perhaps there is no real need to?

@kohkaijie kohkaijie merged commit 69090cc into AY2324S1-CS2103T-T09-3:master Nov 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment