Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester E] add-patient requires both blood type and condition #188

Closed
nus-se-bot opened this issue Nov 3, 2023 · 2 comments · Fixed by #213
Closed

[PE-D][Tester E] add-patient requires both blood type and condition #188

nus-se-bot opened this issue Nov 3, 2023 · 2 comments · Fixed by #213
Assignees
Labels
documentation Improvements or additions to documentation priority.Medium Do when have time.
Milestone

Comments

@nus-se-bot
Copy link

The following commands give the same error

add-patient n/John Doe ic/S9851586G g/M p/98765432 ec/90123456 e/johnd@example.com a/John street, block 123, #01-01 c/pneumothorax

add-patient n/John Doe ic/S9851586G g/M p/98765432 ec/90123456 e/johnd@example.com a/John street, block 123, #01-01 b/O+

Invalid command format! add-patient: Adds a patient to the address book. Parameters: n/NAME p/PHONE ec/EMERGENCY_CONTACT e/EMAIL a/ADDRESS g/GENDER ic/NRIC c/CONDITIONb/BLOOD TYPE[t/TAG]... Example: add-patient n/Kenny Pickett p/98765432 ec/88884444 e/johnd@example.com a/311, Clementi Ave 2, #02-25 g/M ic/S1234567Z c/COVID b/A+ t/MEDIUM

However, the UG mentions that Blood Type and Condition are optional Format: add-patient n/NAME ic/IC g/GENDER p/PHONE_NUMBER ec/EMERGENCY_CONTACT e/EMAIL a/ADDRESS [t/TAG] [d/DOCTOR] [c/CONDITION] [b/BLOODTYPE] ​


Labels: type.FunctionalityBug severity.Low
original: supermii2/ped#8

@tanveersingh10
Copy link

if we can't change the code we j make both fields compulsory in the user guide? makes sense all patients shd have a blood type and a reason they came to the clinic (condition)

@cmHuang777 cmHuang777 added documentation Improvements or additions to documentation priority.Medium Do when have time. labels Nov 8, 2023
@cmHuang777
Copy link

Also need to update it for the Error message when users did not include bloodtype and condition...

@cmHuang777 cmHuang777 added this to the v1.4 milestone Nov 8, 2023
@cmHuang777 cmHuang777 self-assigned this Nov 8, 2023
@cmHuang777 cmHuang777 mentioned this issue Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority.Medium Do when have time.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants