Branch add appointment #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Typical Addressbook and update DG
…S2103T-T09-3/tp into branch-AddAppointment
This commit adds the AddAppointmentCommand to the project. It also updated the required UI changes to display the appointment in each patient/doctor card. Users should be able to add appointments to the address book and see the newly added appointments in the UI. However, the tests are currently failing. It will be fixed in the next PRs, either by me or by my teammates. Additionally, the current way of writing the code may be violating coding principles and may require changes. I will be looking into it in the next PRs and also discuss with my teammates.
Codecov Report
@@ Coverage Diff @@
## branch-AddAppointment #124 +/- ##
===========================================================
- Coverage 71.84% 70.97% -0.87%
- Complexity 634 641 +7
===========================================================
Files 100 101 +1
Lines 2216 2281 +65
Branches 243 246 +3
===========================================================
+ Hits 1592 1619 +27
- Misses 536 583 +47
+ Partials 88 79 -9
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmHuang777
requested review from
tanveersingh10,
chonguschonguschongus and
kohkaijie
kohkaijie
approved these changes
Oct 31, 2023
Mohammed-Faizzzz
merged commit 157043a
into
AY2324S1-CS2103T-T09-3:branch-AddAppointment
3 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the AddAppointmentCommand to the project. It also updated the required UI changes to display the appointment on each patient/doctor card. Users should be able to add appointments to the address book and see the newly added appointments in the UI.
However, the tests are currently failing. It will be fixed in the next
PRs, either by me or by my teammates. Additionally, the current way of writing the code may be violating coding principles and may require changes. (more specifically the part on executing the add patient command) I will be looking into it in the next PRs and also discuss it with my teammates.