Improve code coverage #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
============================================
+ Coverage 72.93% 73.10% +0.17%
- Complexity 587 590 +3
============================================
Files 96 96
Lines 2017 2019 +2
Branches 203 204 +1
============================================
+ Hits 1471 1476 +5
+ Misses 481 479 -2
+ Partials 65 64 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chonguschonguschongus
requested review from
Mohammed-Faizzzz,
tanveersingh10 and
kohkaijie
tanveersingh10
approved these changes
Oct 31, 2023
src/test/java/seedu/address/logic/parser/KeywordParserTest.java
Outdated
Show resolved
Hide resolved
|
|
||
| // same values -> returns true | ||
| GenderPredicate firstPredicateCopy = new GenderPredicate(firstPredicateKeyword); | ||
| assertTrue(firstPredicate.equals(firstPredicateCopy)); |
There was a problem hiding this comment.
Good job adding comments to make code more readable
cmHuang777
approved these changes
Oct 31, 2023
src/test/java/seedu/address/logic/parser/KeywordParserTest.java
Outdated
Show resolved
Hide resolved
src/main/java/seedu/address/logic/parser/AddressBookParser.java
Outdated
Show resolved
Hide resolved
chonguschonguschongus
merged commit c68176d
into
AY2324S1-CS2103T-T09-3:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more test cases to improve code coverage as well as a DoctorUtil class for testing AddDoctorCommand and its parser.
Moving forwards, I will try to write more test cases for AddDoctorCommand and its parser.