Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent editing IC & UG for find-appt #149

Merged
merged 7 commits into from
Nov 2, 2023

Conversation

tanveersingh10
Copy link

No description provided.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #149 (6982e55) into master (7e6ac84) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 6982e55 differs from pull request most recent head 2fb5d81. Consider uploading reports for the commit 2fb5d81 to get more accurate results

@@             Coverage Diff              @@
##             master     #149      +/-   ##
============================================
+ Coverage     66.16%   66.20%   +0.03%     
+ Complexity      638      637       -1     
============================================
  Files           111      111              
  Lines          2521     2515       -6     
  Branches        253      254       +1     
============================================
- Hits           1668     1665       -3     
+ Misses          756      752       -4     
- Partials         97       98       +1     
Files Coverage Δ
...java/seedu/address/logic/commands/EditCommand.java 90.90% <100.00%> (-1.73%) ⬇️
...address/logic/commands/FindAppointmentCommand.java 31.57% <ø> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 88.37% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@chonguschonguschongus chonguschonguschongus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanveersingh10 tanveersingh10 changed the title Prevent editing person's IC Prevent editing IC & UG for find-appt Nov 2, 2023
@kohkaijie kohkaijie merged commit 2f1dc7e into AY2324S1-CS2103T-T09-3:master Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants