Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to find Appointments by ICs of those involved #151

Conversation

chonguschonguschongus
Copy link

Add functionality of searching appointments by NRICs of those involved. NRIC used in query IS case sensitive. Only one NRIC can be searched with at a time.

Make minor adjustment to Ui: Appointments column is thinner and text wrapping is enabled for it.

Moving forwards, not sure if we are implmenting an AppointmentTime class for an AppointmentTime field belonging to the Appointment class. Doing so will make it much easier to implement a search by Day and Time feature.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #151 (053aa58) into master (ddf47f6) will decrease coverage by 0.22%.
The diff coverage is 47.91%.

@@             Coverage Diff              @@
##             master     #151      +/-   ##
============================================
- Coverage     66.58%   66.37%   -0.22%     
- Complexity      629      638       +9     
============================================
  Files           108      111       +3     
  Lines          2466     2513      +47     
  Branches        250      253       +3     
============================================
+ Hits           1642     1668      +26     
- Misses          732      748      +16     
- Partials         92       97       +5     
Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 57.14% <ø> (ø)
...java/seedu/address/logic/commands/ListCommand.java 100.00% <100.00%> (ø)
...ress/logic/parser/AddAppointmentCommandParser.java 0.00% <ø> (ø)
...s/logic/parser/DeleteAppointmentCommandParser.java 100.00% <ø> (ø)
...eedu/address/logic/parser/DeleteCommandParser.java 100.00% <ø> (ø)
.../seedu/address/logic/parser/EditCommandParser.java 88.37% <ø> (ø)
.../seedu/address/logic/parser/FindCommandParser.java 100.00% <ø> (ø)
.../address/logic/commands/AddAppointmentCommand.java 0.00% <0.00%> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 75.00% <0.00%> (-2.78%) ⬇️
...ess/logic/parser/FindAppointmentCommandParser.java 91.66% <91.66%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@tanveersingh10 tanveersingh10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@chonguschonguschongus chonguschonguschongus merged commit 8c330cc into AY2324S1-CS2103T-T09-3:master Nov 2, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants