Update User Guide #215
Merged
Update User Guide #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added parameter table containing specifications of allowed parameters. Will update rest of the UG in next commit.
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=========================================
Coverage 72.20% 72.20%
Complexity 724 724
=========================================
Files 112 112
Lines 2547 2547
Branches 274 274
=========================================
Hits 1839 1839
Misses 601 601
Partials 107 107
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Updated UG to resolve minor discrepancies and added test cases checking for valid NRIC involving non-caps letter inputs.
Mohammed-Faizzzz
merged commit c6594dd
into
AY2324S1-CS2103T-T09-3:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameter table containing specifications of allowed parameters. Made minor changes in UG which fixes the following issues:
Also changed error mesage in the Ic class to specify that NRIC inputs are case-insensitive: fixes [PE-D][Tester E] Lowercase letters in IC accepted #174
Added test cases to ensure valid NRIC is parsed correctly regardless of lower or upper case.