Fix bug regarding messages for Patients and update UG #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made changes to the format method in Messages.java to add patient fields if the person to be added/deleted is a patient. Updated UG for adding patient and doctors to remove duplicate information already mentioned in the parameters table as well as potential errors when adding unspecified prefixes.
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
============================================
+ Coverage 72.20% 72.28% +0.08%
- Complexity 724 725 +1
============================================
Files 112 112
Lines 2547 2555 +8
Branches 274 275 +1
============================================
+ Hits 1839 1847 +8
Misses 601 601
Partials 107 107
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Minor UG changes including: - Ensuring all sentences have full stops. - All duplicate information already included in the parameter table have been removed. - Minor grammar mistakes corrected. - Update Undo and Redo sections to inform users that exiting the app will prevent them from undoing or redoing their previous actions.
cmHuang777
approved these changes
Nov 10, 2023
kohkaijie
requested review from
Mohammed-Faizzzz,
tanveersingh10 and
chonguschonguschongus
Mohammed-Faizzzz
merged commit 4fa3adc
into
AY2324S1-CS2103T-T09-3:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to the format method in Messages.java to add patient fields if the person to be added/deleted is a patient.
Updated UG for adding patient and doctors to remove duplicate information already mentioned in the parameters table as well as potential errors when adding unspecified prefixes. This addresses the issue in #193.
Do help look through the phrasing for how i addressed the above issue as it may not be the most complete.
Attached below is my email to prof Damith verifying that the above bug fix does not violate the feature freeze.
The second commit entails the following minor UG changes:
have been removed.
will prevent them from undoing or redoing their previous actions.