Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test cases and improve code quality #219

Merged

Conversation

cmHuang777
Copy link

  • Added more test cases
  • removed dead code in model class and its implementation

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #219 (f953cd9) into master (c6594dd) will increase coverage by 2.86%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #219      +/-   ##
============================================
+ Coverage     72.20%   75.06%   +2.86%     
- Complexity      724      755      +31     
============================================
  Files           112      112              
  Lines          2547     2531      -16     
  Branches        274      271       -3     
============================================
+ Hits           1839     1900      +61     
+ Misses          601      538      -63     
+ Partials        107       93      -14     
Files Coverage Δ
.../address/logic/commands/AddAppointmentCommand.java 100.00% <ø> (+27.45%) ⬆️
src/main/java/seedu/address/model/AddressBook.java 78.12% <ø> (+6.48%) ⬆️
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
.../main/java/seedu/address/model/person/Patient.java 93.02% <100.00%> (+4.65%) ⬆️
.../java/seedu/address/storage/JsonAdaptedDoctor.java 100.00% <100.00%> (ø)
...java/seedu/address/storage/JsonAdaptedPatient.java 100.00% <100.00%> (+6.25%) ⬆️
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <ø> (+10.00%) ⬆️
...rc/main/java/seedu/address/model/ModelManager.java 89.00% <75.00%> (+7.09%) ⬆️

... and 11 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@cmHuang777 cmHuang777 requested a review from a team November 11, 2023 04:11
@cmHuang777 cmHuang777 added this to the v1.4 milestone Nov 11, 2023
@cmHuang777 cmHuang777 added the priority.High Must have. label Nov 11, 2023
Copy link

@kohkaijie kohkaijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job on adding test cases, code quality changes doesn't seem to cause any conflict as well as test cases are still passing. Well done!

Copy link

@Mohammed-Faizzzz Mohammed-Faizzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on increasing Code Coverage!

@cmHuang777 cmHuang777 merged commit 0abbbc6 into AY2324S1-CS2103T-T09-3:master Nov 11, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must have.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants