Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify UG #220

Merged

Conversation

Mohammed-Faizzzz
Copy link

Modify UG to Address Edge cases associated with add-doctor command.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #220 (423b723) into master (4fa3adc) will increase coverage by 3.08%.
Report is 4 commits behind head on master.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #220      +/-   ##
============================================
+ Coverage     72.28%   75.37%   +3.08%     
- Complexity      725      756      +31     
============================================
  Files           112      112              
  Lines          2555     2530      -25     
  Branches        275      272       -3     
============================================
+ Hits           1847     1907      +60     
+ Misses          601      530      -71     
+ Partials        107       93      -14     
Files Coverage Δ
.../address/logic/commands/AddAppointmentCommand.java 100.00% <ø> (+27.45%) ⬆️
...seedu/address/logic/commands/AddDoctorCommand.java 95.45% <ø> (+13.63%) ⬆️
src/main/java/seedu/address/model/AddressBook.java 78.12% <ø> (+6.48%) ⬆️
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
...a/seedu/address/model/appointment/Appointment.java 92.85% <ø> (+11.77%) ⬆️
.../main/java/seedu/address/model/person/Patient.java 93.02% <100.00%> (+4.65%) ⬆️
.../java/seedu/address/storage/JsonAdaptedDoctor.java 100.00% <100.00%> (ø)
...java/seedu/address/storage/JsonAdaptedPatient.java 100.00% <100.00%> (+6.25%) ⬆️
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <ø> (+10.00%) ⬆️
...rc/main/java/seedu/address/model/ModelManager.java 89.00% <75.00%> (+7.09%) ⬆️

... and 11 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

@kohkaijie kohkaijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Resolved merge conflicts but will create another PR to fine tune the UG to combine both mine and Faiz's parts.

Copy link

@cmHuang777 cmHuang777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions at the add-doctor part seems a bit long, other than that looks good.

@tanveersingh10 tanveersingh10 merged commit 6ffae7b into AY2324S1-CS2103T-T09-3:master Nov 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants