Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for DeleteAppointment and FindAppointment and changed Ui to allow for text wrapping #227

Conversation

chonguschonguschongus
Copy link

Add more test cases for FindAppointment and DeleteAppointment and changed Ui to allow for text wrapping in the cards.

In the midst of writing these, discovered that getTypicalAddressBook() was not getting the appointments properly. Made the change and edited some other test cases acoordingly so it passes.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #227 (5a2f363) into master (4fa3adc) will increase coverage by 6.76%.
Report is 11 commits behind head on master.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master     #227      +/-   ##
============================================
+ Coverage     72.28%   79.05%   +6.76%     
- Complexity      725      785      +60     
============================================
  Files           112      112              
  Lines          2555     2530      -25     
  Branches        275      272       -3     
============================================
+ Hits           1847     2000     +153     
+ Misses          601      439     -162     
+ Partials        107       91      -16     
Files Coverage Δ
.../address/logic/commands/AddAppointmentCommand.java 100.00% <ø> (+27.45%) ⬆️
src/main/java/seedu/address/model/AddressBook.java 81.25% <ø> (+9.60%) ⬆️
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
.../main/java/seedu/address/model/person/Patient.java 93.02% <100.00%> (+4.65%) ⬆️
.../java/seedu/address/storage/JsonAdaptedDoctor.java 100.00% <100.00%> (ø)
...java/seedu/address/storage/JsonAdaptedPatient.java 100.00% <100.00%> (+6.25%) ⬆️
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <ø> (+10.00%) ⬆️
...rc/main/java/seedu/address/model/ModelManager.java 93.00% <75.00%> (+11.09%) ⬆️

... and 20 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

@tanveersingh10 tanveersingh10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@kohkaijie kohkaijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good working on fixing the UI bug and adding new test cases!

@kohkaijie kohkaijie merged commit 8643499 into AY2324S1-CS2103T-T09-3:master Nov 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants