Improve code coverage #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
============================================
+ Coverage 79.07% 79.59% +0.51%
- Complexity 787 791 +4
============================================
Files 112 112
Lines 2538 2538
Branches 271 271
============================================
+ Hits 2007 2020 +13
+ Misses 439 430 -9
+ Partials 92 88 -4
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
kohkaijie
approved these changes
Nov 12, 2023
kohkaijie
reviewed
Nov 12, 2023
| @@ -135,7 +139,7 @@ private Person getEditedPerson(Model model, Person personToEdit) throws CommandE | |||
| editedPerson = createEditedDoctor(doctorToEdit, editPersonDescriptor); | |||
| } | |||
| if (!personToEdit.isSamePerson(editedPerson) && model.hasPerson(editedPerson)) { | |||
| logger.warning("Edited Person and orignal person are the same"); | |||
| logger.warning("Edited Person and original person are the same"); | |||
tanveersingh10
merged commit 80b33bb
into
AY2324S1-CS2103T-T09-3:master
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.