Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UG #229

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Update UG #229

merged 4 commits into from
Nov 12, 2023

Conversation

kohkaijie
Copy link

@kohkaijie kohkaijie commented Nov 12, 2023

Minor UG updates including:

Also added some test cases and minor code quality fixes.

Minor UG updates including:

- Fixes AY2324S1-CS2103T-T09-3#223 regarding undo command restrictions.
- Minor grammar changes.
- Added detail on default behaviour of find command.
@kohkaijie kohkaijie added this to the v1.4 milestone Nov 12, 2023
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #229 (fcccf9e) into master (8643499) will increase coverage by 0.51%.
Report is 3 commits behind head on master.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #229      +/-   ##
============================================
+ Coverage     79.07%   79.59%   +0.51%     
- Complexity      787      791       +4     
============================================
  Files           112      112              
  Lines          2538     2538              
  Branches        271      271              
============================================
+ Hits           2007     2020      +13     
+ Misses          439      430       -9     
+ Partials         92       88       -4     
Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 94.11% <ø> (ø)
...java/seedu/address/logic/parser/KeywordParser.java 93.75% <100.00%> (ø)
...in/java/seedu/address/logic/parser/ParserUtil.java 94.68% <ø> (ø)
...edu/address/model/appointment/AppointmentTime.java 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Fixes wrong error message for invalid appointment time.
Copy link

@tanveersingh10 tanveersingh10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Added some test cases for parsing bloodType and condition in the
ParserUtil class as well as removing some dead code.
Copy link

@cmHuang777 cmHuang777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kohkaijie kohkaijie merged commit c054928 into AY2324S1-CS2103T-T09-3:master Nov 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unspecified restrictions of UndoCommand and RedoCommand
3 participants