Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG and UG #245

Merged

Conversation

chonguschonguschongus
Copy link

Update UML diagrams for Model as well as make changes to parts of the UG.

Find Blood Type no longer exists.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #245 (fcc8078) into master (a600608) will decrease coverage by 0.16%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #245      +/-   ##
============================================
- Coverage     79.87%   79.72%   -0.16%     
+ Complexity      790      781       -9     
============================================
  Files           111      110       -1     
  Lines          2519     2500      -19     
  Branches        269      266       -3     
============================================
- Hits           2012     1993      -19     
  Misses          419      419              
  Partials         88       88              
Files Coverage Δ
...address/logic/commands/FindAppointmentCommand.java 100.00% <ø> (ø)
...s/logic/parser/DeleteAppointmentCommandParser.java 100.00% <ø> (ø)
...ess/logic/parser/FindAppointmentCommandParser.java 91.66% <ø> (ø)
...java/seedu/address/logic/parser/KeywordParser.java 90.90% <ø> (-2.85%) ⬇️
...du/address/model/person/UniqueAppointmentList.java 94.59% <ø> (ø)
...a/seedu/address/model/person/UniqueDoctorList.java 100.00% <ø> (ø)
...a/seedu/address/model/person/UniqueObjectList.java 53.84% <ø> (ø)
.../seedu/address/model/person/UniquePatientList.java 100.00% <ø> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

@kohkaijie kohkaijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome detailed UML diagrams!

@chonguschonguschongus chonguschonguschongus added this to the v1.4 milestone Nov 13, 2023
Copy link

@cmHuang777 cmHuang777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Person *--> "1" Name
Person *--> "1" Phone
Person *--> "1" Address
Person *--> "1" Appointments

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be '*' Appointment instead? just like Tag

@kohkaijie kohkaijie merged commit 93b05d4 into AY2324S1-CS2103T-T09-3:master Nov 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants