Merge pull request #200 from lordidiot/fix-birthday

Fix inaccurate birthday notification behaviour
AY2324S1-CS2103T-T13-2 · Nov 7, 2023 · ada8718 · ada8718
2 parents e706707 + 6471e73
commit ada8718
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/java/seedu/address/model/event/EventFactory.java b/src/main/java/seedu/address/model/event/EventFactory.java
@@ -42,19 +42,19 @@ private static List<Event> createBirthdayEvents(Model model) {
                     );
 
             // Birthday has not passed this year
-            if (birthdayThisYear.isAfter(LocalDate.now())) {
+            if (birthdayThisYear.isAfter(LocalDate.now()) || birthdayThisYear.equals(LocalDate.now())) {
                 event = new Event(
                         String.format("%s's Birthday", person.getName()), "",
-                        birthdayThisYear.atTime(0, 0)
+                        birthdayThisYear.atTime(23, 59)
                 );
             } else {
                 event = new Event(
                         String.format("%s's Birthday", person.getName()), "",
-                        birthdayNextYear.atTime(0, 0)
+                        birthdayNextYear.atTime(23, 59)
                 );
             }
 
-            event.addReminder(Duration.ofDays(1)); // Birthday reminder defaults to 1 day in advance
+            event.addReminder(Duration.ofDays(2)); // Birthday reminder within 1 day of the birthday
             event.addMember(person);
             events.add(event);
         }