This repository has been archived by the owner on Apr 6, 2024. It is now read-only.
Restrict all command input to ASCII #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #148 +/- ##
============================================
+ Coverage 82.75% 82.78% +0.02%
- Complexity 754 755 +1
============================================
Files 99 99
Lines 2308 2312 +4
Branches 258 259 +1
============================================
+ Hits 1910 1914 +4
Misses 333 333
Partials 65 65
☔ View full report in Codecov by Sentry. |
lordidiot
reviewed
Nov 2, 2023
lordidiot
suggested changes
Nov 2, 2023
| @Test | ||
| public void parseCommand_allAsciiInputAllowed() { | ||
| AddressBookParser parser = new AddressBookParser(); | ||
| for (char c = '!'; c <= '~'; c++) { |
There was a problem hiding this comment.
Shouldn't this start with space?
Suggested change
| for (char c = '!'; c <= '~'; c++) { | |
| for (char c = ' '; c <= '~'; c++) { |
There was a problem hiding this comment.
Space gets trimmed and gets a different error. Starting with '!' is correct.
There was a problem hiding this comment.
Changed test case in #f7e1736
src/main/java/seedu/address/logic/parser/AddressBookParser.java
Outdated
Show resolved
Hide resolved
Co-authored-by: lordidiot <0xlordidiot@gmail.com>
limjunxian1
approved these changes
Nov 2, 2023
lordidiot
approved these changes
Nov 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #147