Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Add update photo feature to Developer Guide #155

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

VN-Hao
Copy link

@VN-Hao VN-Hao commented Nov 2, 2023

Closes #153

@VN-Hao VN-Hao added the priority.High Must do label Nov 2, 2023
@VN-Hao VN-Hao added this to the v1.3b milestone Nov 2, 2023
@VN-Hao VN-Hao self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec1d68c) 82.78% compared to head (a9b2b44) 82.78%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #155   +/-   ##
=========================================
  Coverage     82.78%   82.78%           
  Complexity      755      755           
=========================================
  Files            99       99           
  Lines          2312     2312           
  Branches        259      259           
=========================================
  Hits           1914     1914           
  Misses          333      333           
  Partials         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@limjunxian1 limjunxian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM! seems like you followed the format and flow of content as per notes feature. We can always take the formatting and layout of our content in DG to be settled in 1.4. Happy to merge this for now due to the time limitations of 1.3b! Just a few pointers to keep in mind and we can work towards:

  1. Sequence diagram can afford to omit low level details
  2. Design considerations to be inserted into your section. You can refer to other features that already elaborates on them for a rough guideline.

@VN-Hao VN-Hao merged commit 28cbc0a into AY2324S1-CS2103T-T13-2:master Nov 2, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add description for update photo feature in DeveloperGuide.md
2 participants