Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Correct UserGuide.md bugs #156

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

limjunxian1
Copy link

Refer to #154 for what this PR does. Closes #154

@limjunxian1 limjunxian1 added this to the v1.3b milestone Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (906ffcf) 82.75% compared to head (ef1db11) 82.78%.
Report is 14 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
+ Coverage     82.75%   82.78%   +0.02%     
- Complexity      754      755       +1     
============================================
  Files            99       99              
  Lines          2308     2312       +4     
  Branches        258      259       +1     
============================================
+ Hits           1910     1914       +4     
  Misses          333      333              
  Partials         65       65              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conradsoon conradsoon self-requested a review November 2, 2023 12:50
Copy link

@conradsoon conradsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Markbind builds locally.
  • Image replaced correctly.
  • Jar renamed to CampusConnect.jar correctly.

conradsoon

This comment was marked as outdated.

Copy link

@conradsoon conradsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings / Error Cases for features will be shown in a yellow box with this exclamation mark icon :fa-solid-exclamation: . These clarify cases which will are expected to display errors to users, or explain enhancements that will be implemented in future releases of CampusConnect.

Which will are should be which are (UserGuide.md Line 77)

@limjunxian1
Copy link
Author

Warnings / Error Cases for features will be shown in a yellow box with this exclamation mark icon :fa-solid-exclamation: . These clarify cases which will are expected to display errors to users, or explain enhancements that will be implemented in future releases of CampusConnect.

Which will are should be which are (UserGuide.md Line 77)

thank you for pointing that out! fixed in ef1db11

Copy link

@conradsoon conradsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing up the UserGuide. Have taken a read through again and don't spot any other grammatical/language mistakes. LGTM.

@limjunxian1 limjunxian1 merged commit e4cc144 into AY2324S1-CS2103T-T13-2:master Nov 2, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor edits to UserGuide.md
2 participants