-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
=========================================
Coverage 82.78% 82.78%
Complexity 755 755
=========================================
Files 99 99
Lines 2312 2312
Branches 259 259
=========================================
Hits 1914 1914
Misses 333 333
Partials 65 65 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM! thanks for tidying up the use cases but there are some use cases currently missing also, e.g. updatephoto
and removenote
. otherwise, happy to merge this!
Co-authored-by: limjunxian1 <122253543+limjunxian1@users.noreply.github.com>
Co-authored-by: limjunxian1 <122253543+limjunxian1@users.noreply.github.com>
Thank you for the feedback @limjunxian1, have addressed the issues. PTAL! |
thanks @lordidiot for the quick fixes! LGTM and thank you for writing use cases on the group's behalf! |
No description provided.