Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Update DG with usecases #157

Merged
merged 9 commits into from
Nov 2, 2023

Conversation

lordidiot
Copy link

No description provided.

@lordidiot lordidiot added this to the v1.3b milestone Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3394a5f) 82.78% compared to head (bfc5c77) 82.78%.
Report is 9 commits behind head on master.

❗ Current head bfc5c77 differs from pull request most recent head 41714bb. Consider uploading reports for the commit 41714bb to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #157   +/-   ##
=========================================
  Coverage     82.78%   82.78%           
  Complexity      755      755           
=========================================
  Files            99       99           
  Lines          2312     2312           
  Branches        259      259           
=========================================
  Hits           1914     1914           
  Misses          333      333           
  Partials         65       65           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@limjunxian1 limjunxian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM! thanks for tidying up the use cases but there are some use cases currently missing also, e.g. updatephoto and removenote. otherwise, happy to merge this!

docs/DeveloperGuide.md Show resolved Hide resolved
docs/DeveloperGuide.md Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
lordidiot and others added 4 commits November 2, 2023 23:16
Co-authored-by: limjunxian1 <122253543+limjunxian1@users.noreply.github.com>
Co-authored-by: limjunxian1 <122253543+limjunxian1@users.noreply.github.com>
@lordidiot
Copy link
Author

Thank you for the feedback @limjunxian1, have addressed the issues. PTAL!

@limjunxian1
Copy link

thanks @lordidiot for the quick fixes! LGTM and thank you for writing use cases on the group's behalf!

@lordidiot lordidiot merged commit ec1d68c into AY2324S1-CS2103T-T13-2:master Nov 2, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants