This repository has been archived by the owner on Apr 6, 2024. It is now read-only.
forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
Update DG & UG for Find / Payments #159
Merged
kokrui
merged 15 commits into
AY2324S1-CS2103T-T13-2:master
from
kokrui:payment-ug-dg-ref
Nov 2, 2023
Merged
Update DG & UG for Find / Payments #159
kokrui
merged 15 commits into
AY2324S1-CS2103T-T13-2:master
from
kokrui:payment-ug-dg-ref
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
============================================
+ Coverage 82.78% 82.80% +0.02%
+ Complexity 755 753 -2
============================================
Files 99 99
Lines 2312 2315 +3
Branches 259 258 -1
============================================
+ Hits 1914 1917 +3
Misses 333 333
Partials 65 65
☔ View full report in Codecov by Sentry. |
… payment-ug-dg-ref
conradsoon
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Markbind builds successfully
- Program runs
- Messing around with find generally works
- Regex makes sense to me
LGTM
Co-authored-by: Conrad <18553610+conradsoon@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #116