Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Update DG & UG for Find / Payments #159

Merged
merged 15 commits into from
Nov 2, 2023

Conversation

kokrui
Copy link

@kokrui kokrui commented Nov 2, 2023

Closes #116

@kokrui kokrui added this to the v1.4 milestone Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8729e17) 82.78% compared to head (4a54914) 82.80%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #159      +/-   ##
============================================
+ Coverage     82.78%   82.80%   +0.02%     
+ Complexity      755      753       -2     
============================================
  Files            99       99              
  Lines          2312     2315       +3     
  Branches        259      258       -1     
============================================
+ Hits           1914     1917       +3     
  Misses          333      333              
  Partials         65       65              
Files Coverage Δ
.../seedu/address/logic/parser/FindCommandParser.java 100.00% <100.00%> (ø)
...edu/address/logic/parser/FindExpressionParser.java 95.83% <100.00%> (-0.04%) ⬇️
...ddress/logic/parser/FindFilterStringTokenizer.java 96.66% <95.45%> (+0.23%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kokrui kokrui modified the milestones: v1.4, v1.3b Nov 2, 2023
Copy link

@conradsoon conradsoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Markbind builds successfully
  • Program runs
  • Messing around with find generally works
  • Regex makes sense to me
    LGTM

docs/UserGuide.md Outdated Show resolved Hide resolved
kokrui and others added 2 commits November 3, 2023 00:53
Co-authored-by: Conrad <18553610+conradsoon@users.noreply.github.com>
@kokrui kokrui merged commit 9e1b26a into AY2324S1-CS2103T-T13-2:master Nov 2, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve code quality for Find command parsing classes
2 participants