Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Update ppp #211

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

limjunxian1
Copy link

Closes #210

@limjunxian1 limjunxian1 added this to the v1.4 milestone Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ada8718) 82.50% compared to head (2e485ef) 82.61%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #211      +/-   ##
============================================
+ Coverage     82.50%   82.61%   +0.10%     
- Complexity      753      754       +1     
============================================
  Files            99       99              
  Lines          2327     2335       +8     
  Branches        261      261              
============================================
+ Hits           1920     1929       +9     
+ Misses          339      337       -2     
- Partials         68       69       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@lordidiot lordidiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for all the great contributions to the team thus far 👍
Left one suggestion you should accept before merging this.


## Review / Mentoring Contributions

to be added soon
* Pull Requests reviewed: 23 [(GitHub)](https://github.com/AY2324S1-CS2103T-T13-2/tp/pulls?q=is%3Apr+is%3Aclosed+reviewed-by%3A%40me)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Pull Requests reviewed: 23 [(GitHub)](https://github.com/AY2324S1-CS2103T-T13-2/tp/pulls?q=is%3Apr+is%3Aclosed+reviewed-by%3A%40me)
* Pull Requests reviewed: 23 [(GitHub)](https://github.com/AY2324S1-CS2103T-T13-2/tp/pulls?q=is%3Apr+is%3Aclosed+reviewed-by%3Alimjunxian1)

Derp, minus 5% contribution for this error

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing this out! fixed in 2e485ef

@limjunxian1 limjunxian1 merged commit 04fc277 into AY2324S1-CS2103T-T13-2:master Nov 9, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update personal ppp
2 participants