This repository has been archived by the owner on Apr 6, 2024. It is now read-only.
Fix updatephoto and notes section of UserGuide as per ped suggestions
#216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
=========================================
Coverage 82.61% 82.61%
Complexity 754 754
=========================================
Files 99 99
Lines 2335 2335
Branches 261 261
=========================================
Hits 1929 1929
Misses 337 337
Partials 69 69 ☔ View full report in Codecov by Sentry. |
VN-Hao
approved these changes
Nov 9, 2023
docs/UserGuide.md
Outdated
Comment on lines
314
to
315
| * If you are a Windows user, click [here](https://www.timeatlas.com/copy-file-path/#:~:text=Select%20your%20file%2C%20right%2Dclick,Ctrl%20%2B%20Shift%20%2B%20%2B%20C%20). | ||
| * If you are a macOS user, click [here](https://technastic.com/copy-file-path-mac/). |
There was a problem hiding this comment.
Given you have written that "To obtain the NEW_PHOTO_PATH of your photo", the "click here" somewhat sounds like you can actually get the path from there. Although I doubt anyone feels the same way in real world scenario, you can consider change it to "learn from here".
It is very minor so no stress 😄
There was a problem hiding this comment.
yes agreed! was not very sure how i can phrase it better, good point raised! fixed in 0f2693b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #190, closes #191