Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Make filtered contact list reactive to contact additions/modifications #217

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

kokrui
Copy link

@kokrui kokrui commented Nov 9, 2023

Resolves #180 as per discussed implementation

@kokrui kokrui added this to the v1.4 milestone Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abcfadc) 82.61% compared to head (d2d0502) 82.59%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #217      +/-   ##
============================================
- Coverage     82.61%   82.59%   -0.03%     
  Complexity      754      754              
============================================
  Files            99       99              
  Lines          2335     2332       -3     
  Branches        261      261              
============================================
- Hits           1929     1926       -3     
  Misses          337      337              
  Partials         69       69              
Files Coverage Δ
...va/seedu/address/logic/commands/AddAltCommand.java 88.50% <ø> (-0.14%) ⬇️
...java/seedu/address/logic/commands/EditCommand.java 94.40% <ø> (-0.05%) ⬇️
...edu/address/logic/commands/UpdatePhotoCommand.java 85.29% <ø> (-0.43%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@lordidiot lordidiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this.

We can think about adding regression tests on all/most commands to ensure that we don't accidentally revert this in future.

@kokrui kokrui merged commit 1144c13 into AY2324S1-CS2103T-T13-2:master Nov 10, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester E] pay command after find causes card to disappear
2 participants