Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Make notes window reactive #227

Merged
merged 4 commits into from
Nov 11, 2023

Conversation

kokrui
Copy link

@kokrui kokrui commented Nov 11, 2023

Closes #212

@kokrui kokrui added this to the v1.4 milestone Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (33db2cf) 82.72% compared to head (499bd40) 82.73%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #227   +/-   ##
=========================================
  Coverage     82.72%   82.73%           
- Complexity      763      767    +4     
=========================================
  Files           100      100           
  Lines          2356     2363    +7     
  Branches        262      263    +1     
=========================================
+ Hits           1949     1955    +6     
  Misses          337      337           
- Partials         70       71    +1     
Files Coverage Δ
...c/main/java/seedu/address/model/person/Person.java 100.00% <100.00%> (ø)
src/main/java/seedu/address/ui/NotesWindow.java 93.02% <80.00%> (-1.72%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@lordidiot lordidiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this, works as expected 👍

@kokrui kokrui merged commit ac92810 into AY2324S1-CS2103T-T13-2:master Nov 11, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notes window not reactive
2 participants