Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Improve find code quality, fix find-by-tag casing bug #230

Merged
merged 7 commits into from
Nov 11, 2023

Conversation

kokrui
Copy link

@kokrui kokrui commented Nov 11, 2023

Closes #229
Closes #228

@kokrui kokrui added this to the v1.4 milestone Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (33db2cf) 82.72% compared to head (9baa582) 82.75%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #230      +/-   ##
============================================
+ Coverage     82.72%   82.75%   +0.02%     
- Complexity      763      769       +6     
============================================
  Files           100      100              
  Lines          2356     2383      +27     
  Branches        262      264       +2     
============================================
+ Hits           1949     1972      +23     
- Misses          337      340       +3     
- Partials         70       71       +1     
Files Coverage Δ
...in/java/seedu/address/commons/util/StringUtil.java 96.66% <100.00%> (+0.83%) ⬆️
...java/seedu/address/logic/commands/FindCommand.java 100.00% <ø> (ø)
...edu/address/logic/parser/FindExpressionParser.java 94.02% <87.17%> (-1.81%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@lordidiot lordidiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Appreciate the detailed javadocs and the additional comments for future developers to better understand the codebase.

@kokrui kokrui merged commit b27bdb6 into AY2324S1-CS2103T-T13-2:master Nov 11, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve SLAP for find command code Find by tag isn't actually case-insensitive
2 participants