Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Transactions above 20k now show correct error message #233

Merged
merged 6 commits into from
Nov 12, 2023

Conversation

kokrui
Copy link

@kokrui kokrui commented Nov 12, 2023

Closes #232

@kokrui kokrui added this to the v1.4 milestone Nov 12, 2023
Copy link

@lordidiot lordidiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Appreciate the addition of tests and more verbose naming.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b27bdb6) 82.83% compared to head (1ae1a16) 83.02%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #233      +/-   ##
============================================
+ Coverage     82.83%   83.02%   +0.18%     
- Complexity      773      777       +4     
============================================
  Files           100      100              
  Lines          2377     2380       +3     
  Branches        267      267              
============================================
+ Hits           1969     1976       +7     
+ Misses          338      336       -2     
+ Partials         70       68       -2     
Files Coverage Δ
...in/java/seedu/address/logic/parser/ParserUtil.java 97.26% <100.00%> (+0.07%) ⬆️
.../main/java/seedu/address/model/person/Balance.java 100.00% <100.00%> (+16.66%) ⬆️
.../java/seedu/address/storage/JsonAdaptedPerson.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kokrui kokrui merged commit 45aaf59 into AY2324S1-CS2103T-T13-2:master Nov 12, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transaction amount exceed 20k doesn't show error message in app
2 participants