Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Fix package name typo and outdated AB3 links in DG #239

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

kokrui
Copy link

@kokrui kokrui commented Nov 13, 2023

Closes #238

thanku @rocketninja7 for catching package name

@kokrui kokrui added this to the v1.4 milestone Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45aaf59) 83.02% compared to head (0b7bad3) 83.02%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #239   +/-   ##
=========================================
  Coverage     83.02%   83.02%           
  Complexity      777      777           
=========================================
  Files           100      100           
  Lines          2380     2380           
  Branches        267      267           
=========================================
  Hits           1976     1976           
  Misses          336      336           
  Partials         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@limjunxian1 limjunxian1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the quick changes as suggested by our classmate!

@@ -952,7 +952,7 @@ testers are expected to do more *exploratory* testing.
4. **Test case:** `owe 1 50000`<br>
**Expected:** You will not owe the first `Person` in the list $50000. Error details shown in the status message.

2. To see if the money the `Person` owes is recorded, use the [find command](https://ay2324s1-cs2103t-t13-2.github.io/tp/UserGuide.html#view-notes-of-contact-viewnotes) to search for the `Person` and verify the money owed.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @conradsoon fixed here! thanks for the catch

@kokrui kokrui merged commit 202e242 into AY2324S1-CS2103T-T13-2:master Nov 13, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix package name typo and other AB3 links in DG
2 participants