Skip to content
This repository has been archived by the owner on Apr 6, 2024. It is now read-only.

Update updatephoto DG #246

Merged

Conversation

lordidiot
Copy link

This PR fixes some typos and outdated logic in the DG, also updates the diagram for accuracy

@lordidiot lordidiot added this to the v1.4 milestone Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bc9b46) 83.02% compared to head (e5051e7) 83.02%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #246   +/-   ##
=========================================
  Coverage     83.02%   83.02%           
  Complexity      777      777           
=========================================
  Files           100      100           
  Lines          2380     2380           
  Branches        267      267           
=========================================
  Hits           1976     1976           
  Misses          336      336           
  Partials         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kokrui kokrui self-requested a review November 13, 2023 16:53
Copy link

@kokrui kokrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching and fixing!

@lordidiot lordidiot merged commit b6c6a85 into AY2324S1-CS2103T-T13-2:master Nov 13, 2023
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants