Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swift #469

Conversation

juliusgambe
Copy link

Re pull request

@juliusgambe juliusgambe self-assigned this Nov 9, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (421102d) 83.97% compared to head (7d72cae) 83.97%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #469   +/-   ##
=========================================
  Coverage     83.97%   83.97%           
  Complexity      977      977           
=========================================
  Files           121      121           
  Lines          2895     2895           
  Branches        342      342           
=========================================
  Hits           2431     2431           
  Misses          397      397           
  Partials         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@zhonghan721 zhonghan721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliusgambe juliusgambe merged commit b33336e into AY2324S1-CS2103T-T13-3:master Nov 10, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants