Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug - Delivery details not updated #482

Conversation

zhonghan721
Copy link

Delivery details associated with edited customer are not updated automatically

@zhonghan721 zhonghan721 added type.Bug Something isn't working priority.High labels Nov 10, 2023
@zhonghan721 zhonghan721 self-assigned this Nov 10, 2023
@zhonghan721 zhonghan721 added this to the V1.4 milestone Nov 10, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e3ad703) 83.98% compared to head (37cda12) 83.95%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #482      +/-   ##
============================================
- Coverage     83.98%   83.95%   -0.03%     
- Complexity      995     1002       +7     
============================================
  Files           121      121              
  Lines          2959     2979      +20     
  Branches        353      357       +4     
============================================
+ Hits           2485     2501      +16     
+ Misses          389      388       -1     
- Partials         85       90       +5     
Files Coverage Δ
...rc/main/java/seedu/address/model/DeliveryBook.java 86.11% <100.00%> (+0.39%) ⬆️
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 99.46% <100.00%> (+<0.01%) ⬆️
...edu/address/model/delivery/UniqueDeliveryList.java 88.88% <100.00%> (+0.20%) ⬆️
...in/java/seedu/address/model/delivery/Delivery.java 84.33% <50.00%> (+0.42%) ⬆️
...s/logic/commands/customer/CustomerEditCommand.java 92.66% <77.27%> (-3.94%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhonghan721 zhonghan721 marked this pull request as ready for review November 11, 2023 02:43
@jianyangg
Copy link

Close #481

Copy link

@juliusgambe juliusgambe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some general comments

Copy link

@juliusgambe juliusgambe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@juliusgambe juliusgambe merged commit 261c1f2 into AY2324S1-CS2103T-T13-3:master Nov 12, 2023
3 of 5 checks passed
@zhonghan721 zhonghan721 linked an issue Nov 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High type.Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Delivery address not updated
3 participants