Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mentions of PersonCard to ItemCard - DG Ui #488

Conversation

jianyangg
Copy link

@jianyangg jianyangg commented Nov 11, 2023

as per Gambe's code name change update.

Need help checking if ItemCard has reference to Model.
Checking the code, I see no references to Model in ItemCard.java.
The access to Model in our code is done through Logic, so our
Ui class diagram may not be consistent with other groups'.

Close #487

as per Gambe's code name change update
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (497b56b) 83.97% compared to head (d04e162) 83.97%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #488   +/-   ##
=========================================
  Coverage     83.97%   83.97%           
  Complexity      977      977           
=========================================
  Files           121      121           
  Lines          2895     2895           
  Branches        342      342           
=========================================
  Hits           2431     2431           
  Misses          397      397           
  Partials         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@juliusgambe juliusgambe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't think it is referenced in Model or ModelManager. Only ListItem which is our data structure to represent items in an ItemCard. Thanks for helping to change the name.

@juliusgambe juliusgambe merged commit 296194c into AY2324S1-CS2103T-T13-3:master Nov 12, 2023
5 checks passed
@jianyangg jianyangg changed the title DG Ui - Change mentions of PersonCard to ItemCard Change mentions of PersonCard to ItemCard - DG Ui Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update DG - UI class diagram
2 participants