-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup ModelManager #493
Cleanup ModelManager #493
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #493 +/- ##
============================================
+ Coverage 83.97% 84.02% +0.04%
- Complexity 977 984 +7
============================================
Files 121 121
Lines 2895 2904 +9
Branches 342 342
============================================
+ Hits 2431 2440 +9
Misses 397 397
Partials 67 67
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for adding these. We have to remember to remove deprecated methods once everyone made their changes.
Closes #490
Cleanup Model Manager
New Methods
Customer
showAllCustomerList()
May impact:
CustomerEditCommand
,CustomerListCommand
,UserLoginCommand
getFilteredCustomerListSize()
May impact:
CustomerFind
isFilteredCustomerListEmpty()
May impact:
CustomerList
Delivery
showAllDeliveryList()
May impact:
DeliveryEditCommand
,DeliveryListCommand
getFilteredDeliveryListSize()
isFilteredDeliveryListEmpty()
isSortedDeliveryListEmpty()
Other Changes