Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ModelManager #493

Merged
merged 6 commits into from
Nov 11, 2023
Merged

Conversation

juliusgambe
Copy link

Closes #490

Cleanup Model Manager

New Methods

Customer

  1. showAllCustomerList()
    May impact: CustomerEditCommand, CustomerListCommand, UserLoginCommand

  2. getFilteredCustomerListSize()
    May impact: CustomerFind

  3. isFilteredCustomerListEmpty()
    May impact: CustomerList

Delivery

  1. showAllDeliveryList()
    May impact: DeliveryEditCommand, DeliveryListCommand

  2. getFilteredDeliveryListSize()

  3. isFilteredDeliveryListEmpty()

  4. isSortedDeliveryListEmpty()

Other Changes

  1. Extracted out transformers for LOD
  2. Refractor guard statements to emphasise happy paths instead

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (497b56b) 83.97% compared to head (9b3fe30) 84.02%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #493      +/-   ##
============================================
+ Coverage     83.97%   84.02%   +0.04%     
- Complexity      977      984       +7     
============================================
  Files           121      121              
  Lines          2895     2904       +9     
  Branches        342      342              
============================================
+ Hits           2431     2440       +9     
  Misses          397      397              
  Partials         67       67              
Files Coverage Δ
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
...rc/main/java/seedu/address/model/ModelManager.java 99.44% <100.00%> (+0.02%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jianyangg jianyangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding these. We have to remember to remove deprecated methods once everyone made their changes.

@jianyangg jianyangg merged commit 6193d42 into master Nov 11, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelManager - Improve Code Quality
5 participants