Update DG (JY) #505
Merged
Update DG (JY) #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated implementation for register account in terms of: * Sequence diagram * Activity diagram * Their descriptive text
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #505 +/- ##
=========================================
Coverage 84.35% 84.35%
Complexity 1029 1029
=========================================
Files 121 121
Lines 3158 3158
Branches 370 370
=========================================
Hits 2664 2664
Misses 379 379
Partials 115 115 ☔ View full report in Codecov by Sentry. |
B-enguin
reviewed
Nov 12, 2023
| 1. The user specifies the `USERNAME`{.swift}, `PASSWORD`{.swift}, `CONFIRM_PASSWORD`{.swift}, `SECRET_QUESTION`{.swift} | ||
| and `ANSWER`{.swift} in the `register`{.swift} command. | ||
| 1. If any of the fields is not provided, an error message with the correct command format will be shown. | ||
| 1. If command parameters provided are not within the acceptable value range, an error message with the correct command format will be shown. |
There was a problem hiding this comment.
Would value range sound abit wrong, since its not really a range?
Comment on lines
+371
to
+372
| 1. If not all fields are present, a `ParseException` is thrown saying incorrect command format. | ||
| 1. If all fields are present, it checks if `PASSWORD`{.swift} and `CONFIRM_PASSWORD`{.swift} match. |
There was a problem hiding this comment.
Would a check for password format be missing here?
Gabriel4357
merged commit 35a4088
into
AY2324S1-CS2103T-T13-3:master
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated implementation for register account in terms of:
Close #503