Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality - ZH #506

Conversation

zhonghan721
Copy link

  • Add logging
  • Fix LoD violation in customer find
  • Create model#clearFilteredCustomerList() and model#clearFilteredDeliveryList() for use in user logout
  • Use model#showAllFilteredCustomerList()
  • Fix missing space in error message for duplicate prefixes
  • Remove unused User constructor

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff44e93) 84.02% compared to head (130ff3a) 84.45%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #506      +/-   ##
============================================
+ Coverage     84.02%   84.45%   +0.43%     
- Complexity      984      993       +9     
============================================
  Files           121      121              
  Lines          2904     2934      +30     
  Branches        342      342              
============================================
+ Hits           2440     2478      +38     
+ Misses          397      389       -8     
  Partials         67       67              
Files Coverage Δ
src/main/java/seedu/address/logic/Messages.java 91.66% <ø> (ø)
...ss/logic/commands/customer/CustomerAddCommand.java 100.00% <100.00%> (ø)
...s/logic/commands/customer/CustomerFindCommand.java 100.00% <100.00%> (ø)
.../address/logic/commands/user/UserLoginCommand.java 100.00% <100.00%> (ø)
...address/logic/commands/user/UserLogoutCommand.java 100.00% <100.00%> (ø)
...address/logic/commands/user/UserUpdateCommand.java 95.52% <100.00%> (+0.20%) ⬆️
...ogic/parser/customer/CustomerAddCommandParser.java 100.00% <100.00%> (ø)
...ress/logic/parser/user/UserLoginCommandParser.java 100.00% <100.00%> (ø)
...ess/logic/parser/user/UserUpdateCommandParser.java 95.45% <100.00%> (+0.33%) ⬆️
src/main/java/seedu/address/model/Model.java 100.00% <ø> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@juliusgambe juliusgambe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +36 to +37
model.clearFilteredDeliveryList();
model.clearFilteredCustomerList();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one

@juliusgambe juliusgambe merged commit 473163e into AY2324S1-CS2103T-T13-3:master Nov 11, 2023
5 checks passed
@zhonghan721 zhonghan721 linked an issue Nov 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZH - Improve Code Quality
2 participants