Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging #510

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

B-enguin
Copy link

Added logging to CustomerListCommand, CustomerViewCommand, DeliveryCreateNoteCommand, DeliveryFindCommand, DeliveryStatusCommand.

Closes #509.

Added logging to `CustomerListCommand`, `CustomerViewCommand`,
`DeliveryCreateNoteCommand`, `DeliveryFindCommand`,
`DeliveryStatusCommand`.
@B-enguin B-enguin added this to the V1.4 milestone Nov 11, 2023
@B-enguin B-enguin self-assigned this Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (473163e) 83.98% compared to head (4e25fb7) 84.09%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #510      +/-   ##
============================================
+ Coverage     83.98%   84.09%   +0.11%     
- Complexity      995      998       +3     
============================================
  Files           121      121              
  Lines          2959     2980      +21     
  Branches        353      353              
============================================
+ Hits           2485     2506      +21     
  Misses          389      389              
  Partials         85       85              
Files Coverage Δ
...s/logic/commands/customer/CustomerListCommand.java 100.00% <100.00%> (ø)
...s/logic/commands/customer/CustomerViewCommand.java 87.50% <100.00%> (+2.88%) ⬆️
...c/commands/delivery/DeliveryCreateNoteCommand.java 90.90% <100.00%> (+1.16%) ⬆️
...s/logic/commands/delivery/DeliveryFindCommand.java 88.00% <100.00%> (+2.28%) ⬆️
...logic/commands/delivery/DeliveryStatusCommand.java 90.69% <100.00%> (+1.22%) ⬆️
...elivery/DeliveryNameContainsKeywordsPredicate.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@zhonghan721 zhonghan721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliusgambe juliusgambe merged commit 4d0f735 into AY2324S1-CS2103T-T13-3:master Nov 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Logging
3 participants