-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DG - Implementations #518
Update DG - Implementations #518
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #518 +/- ##
============================================
- Coverage 84.02% 83.90% -0.13%
- Complexity 984 1010 +26
============================================
Files 121 121
Lines 2904 3025 +121
Branches 342 360 +18
============================================
+ Hits 2440 2538 +98
+ Misses 397 389 -8
- Partials 67 98 +31 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some general comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ff7574b
into
AY2324S1-CS2103T-T13-3:master
Closes #516
Update implementations for
login
,logout
,customer add