Logger assertion #526
Merged
Logger assertion #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/AY2324S1-CS2103T-T13-3/tp: (24 commits) Change test Add tests Remove trailing whitespace Add Happy Path Add tests Add methods for LoD Update jianyangg's PPP UG Final Touches Add final adjustments/refinements Add EOF Add draft Fix alignment Add data changes Change all names of person Update PPP Fix swift Add PPP draft Add changes Update whitespacing issues and minor adjustments Add newline to EOF ...
* 'master' of https://github.com/AY2324S1-CS2103T-T13-3/tp: Update UG Update UG according to Zhong Han's comments Improve code quality Add newline at EOF Standardise UG Update methods to use new model.getFilteredCustomerListSize() Improve Code Quality of codebase Add in new challenges and achievements Update glossary Add appendix-effort Update acknowledgment and glossary and NFR
* code-quality-fix: Fix tests Fix tests and checkstyle improve code quality
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #526 +/- ##
============================================
- Coverage 83.90% 83.83% -0.07%
- Complexity 1010 1021 +11
============================================
Files 121 121
Lines 3025 3143 +118
Branches 360 367 +7
============================================
+ Hits 2538 2635 +97
- Misses 389 394 +5
- Partials 98 114 +16
☔ View full report in Codecov by Sentry. |
*add guard clause for customer edit command *ensure happy path for customer edit command *fix customer edit command test
juliusgambe
approved these changes
Nov 13, 2023
juliusgambe
merged commit 4be29df
into
AY2324S1-CS2103T-T13-3:master
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add assertion and logging statements for