Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LoD and Add logging #529

Merged

Conversation

zhonghan721
Copy link

  • Remove use of argMultimap.getPreamble().isEmpty() from
    CustomerAddCommandParser, UserUpdateCommandParser,
    UserLoginCommandParser
  • Add logging to CustomerFindCommandParser

Closes #527

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (534974f) 83.90% compared to head (6552778) 83.91%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #529      +/-   ##
============================================
+ Coverage     83.90%   83.91%   +0.01%     
- Complexity     1010     1011       +1     
============================================
  Files           121      121              
  Lines          3025     3027       +2     
  Branches        360      360              
============================================
+ Hits           2538     2540       +2     
  Misses          389      389              
  Partials         98       98              
Files Coverage Δ
...ogic/parser/customer/CustomerAddCommandParser.java 100.00% <100.00%> (ø)
...gic/parser/customer/CustomerFindCommandParser.java 100.00% <100.00%> (ø)
...ress/logic/parser/user/UserLoginCommandParser.java 100.00% <100.00%> (ø)
...ess/logic/parser/user/UserUpdateCommandParser.java 95.45% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@juliusgambe juliusgambe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliusgambe juliusgambe merged commit f87594e into AY2324S1-CS2103T-T13-3:master Nov 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Quality - LoD, Logging in CustomerFindParser
2 participants