Dg usecase userstory #532
Merged
Dg usecase userstory #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of https://github.com/AY2324S1-CS2103T-T13-3/tp: (24 commits) Change test Add tests Remove trailing whitespace Add Happy Path Add tests Add methods for LoD Update jianyangg's PPP UG Final Touches Add final adjustments/refinements Add EOF Add draft Fix alignment Add data changes Change all names of person Update PPP Fix swift Add PPP draft Add changes Update whitespacing issues and minor adjustments Add newline to EOF ...
* 'master' of https://github.com/AY2324S1-CS2103T-T13-3/tp: Update UG Update UG according to Zhong Han's comments Improve code quality Add newline at EOF Standardise UG Update methods to use new model.getFilteredCustomerListSize() Improve Code Quality of codebase Add in new challenges and achievements Update glossary Add appendix-effort Update acknowledgment and glossary and NFR
* 'master' of https://github.com/AY2324S1-CS2103T-T13-3/tp: Update code based on comments Update DG Manual Testing based on Comments Add logging and assertions Implement Gambe's CQ methods Improve code quality Add missing skinparam tag Update class diagrams Change mentions of PersonCard to ItemCard as per Gambe's code name change update Update UG for password checking Fix failing tests Fix delivery not updated Fix bug of delivery address not updated Update DG based on Comments Add Manual Testing to DG
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #532 +/- ##
============================================
+ Coverage 83.90% 83.96% +0.06%
- Complexity 1010 1026 +16
============================================
Files 121 121
Lines 3025 3094 +69
Branches 360 367 +7
============================================
+ Hits 2538 2598 +60
Misses 389 389
- Partials 98 107 +9 ☔ View full report in Codecov by Sentry. |
zhonghan721
reviewed
Nov 13, 2023
Comment on lines
-1834
to
+1705
| - 1c. Logged-in owner entered date in the wrong format. | ||
| - 1c. Logged-in owner did not specifiy a Delivery ID. | ||
|
|
||
| - 1c1. DMS informs the logged-in owner of invalid format and shows the correct format. | ||
| - 1c1. DMS informs the logged-in Owner to specify a Delivery to update. |
There was a problem hiding this comment.
Perhaps it will be good to talk about the invalid date format/invalid date.
| @@ -1318,21 +1318,21 @@ otherwise) | |||
|
|
|||
| **Extensions:** | |||
There was a problem hiding this comment.
Perhaps can add in the case for duplicated fields/prefixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Use Case and User stories