Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test Coverage for non-trivial paths #540

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

B-enguin
Copy link

Add Testing for,

  • AddressBookParser
  • CustomerDeleteCommand
  • JsonAdaptedCustomer
  • LogicManager

Bug fix for incorrect error message in JsonAdaptedCustomer

Closes #535.

Add Testing for,
- AddressBookParser
- CustomerDeleteCommand
- JsonAdaptedCustomer
- LogicManager

Bug fix for incorrect error message in JsonAdaptedCustomer/
@B-enguin B-enguin added this to the V1.4 milestone Nov 13, 2023
@B-enguin B-enguin self-assigned this Nov 13, 2023
Add Testing for,
- AddressBookParser
- CustomerDeleteCommand
- JsonAdaptedCustomer
- LogicManager

Bug fix for incorrect error message in JsonAdaptedCustomer.
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2bf251c) 84.35% compared to head (dfe9d64) 85.04%.
Report is 45 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #540      +/-   ##
============================================
+ Coverage     84.35%   85.04%   +0.69%     
- Complexity     1029     1034       +5     
============================================
  Files           121      121              
  Lines          3158     3150       -8     
  Branches        370      370              
============================================
+ Hits           2664     2679      +15     
+ Misses          379      358      -21     
+ Partials        115      113       -2     
Files Coverage Δ
...c/main/java/seedu/address/model/delivery/Note.java 100.00% <100.00%> (ø)
...ava/seedu/address/storage/JsonAdaptedCustomer.java 100.00% <100.00%> (+9.30%) ⬆️
...ava/seedu/address/storage/JsonAdaptedDelivery.java 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@B-enguin B-enguin marked this pull request as ready for review November 13, 2023 12:06
Copy link

@juliusgambe juliusgambe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juliusgambe juliusgambe merged commit bf48900 into AY2324S1-CS2103T-T13-3:master Nov 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final Test Coverage Verification
2 participants